-
Notifications
You must be signed in to change notification settings - Fork 1.9k
AUTOSCALE-236: Add cluster-resource-override-admission-operator OLM upgrade tests #64990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUTOSCALE-236: Add cluster-resource-override-admission-operator OLM upgrade tests #64990
Conversation
@maxcao13: This pull request references AUTOSCALE-236 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.20.0" version, but multiple target versions were set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
f1b909a
to
c37eddc
Compare
Okay I believe the previous failure is happening bc master is not up to date with 4.20... (release chores not done) Let's just check that 4.18 -> 4.19 upgrade tests pass using this workflow first. /pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
c37eddc
to
c809bcb
Compare
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade Try again? Not really sure why there's suddenly permission errors. |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
c809bcb
to
1d97093
Compare
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1d97093
to
b139674
Compare
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
b139674
to
2caa7ea
Compare
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-e2e-aws-upgrade |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
2caa7ea
to
d4885ea
Compare
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.20-e2e-aws-upgrade |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
d4885ea
to
d3e9e8a
Compare
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-main-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.20-e2e-aws-upgrade This should work now that I've added the |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
d3e9e8a
to
74bc084
Compare
74bc084
to
7d6331b
Compare
|
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@maxcao13: job(s): pj-rehearse, pj-rehearse either don't exist or were not found to be affected, and cannot be rehearsed |
7d6331b
to
ee8508f
Compare
/pj-rehearse pull-ci-openshift-cluster-resource-override-admission-operator-release-4.17-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.18-e2e-aws-upgrade pull-ci-openshift-cluster-resource-override-admission-operator-release-4.19-e2e-aws-upgrade |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
@maxcao13: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/test config |
CRO changes look good, excited to have the "safety net" of upgrade tests. Thanks Max! Are the VPA changes somehow related to what's going on in the CRO? They seem completely unrelated to AUTOSCALE-236. Is there a reason we just don't just do that with VPA chores? |
No, not really I just changed it here so we wouldn't have to come back here and PR again, but I can revert that part so the changes can be in the right contexts. |
Signed-off-by: Max Cao <[email protected]>
ee8508f
to
b9daef7
Compare
/pj-rehearse ack |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
[REHEARSALNOTIFIER]
A total of 43 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
Awesome, thanks! (I'll even volunteer to do the VPA chore version bump because I was "that guy" 😛 ) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkyros, maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/pj-rehearse ack |
@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Signed-off-by: Max Cao <[email protected]>
Fixes: AUTOSCALE-236
Also bumps the vpa operator images for upgrade tests for convenience.